[SPARK-55992][SQL] Fix GroupPartitions textual representation#54801
Closed
peter-toth wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55992][SQL] Fix GroupPartitions textual representation#54801peter-toth wants to merge 1 commit intoapache:masterfrom
peter-toth wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
dongjoon-hyun
approved these changes
Mar 16, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @peter-toth .
Sorry for the delay. I was sick during the weekend.
Contributor
Author
Thank you @dongjoon-hyun , no problem. Hope you feeling better now. |
Member
|
hi @peter-toth @dongjoon-hyun , i took a look at the pr, and had some small comment. As its merged, I just made a pr here: #54842 , can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves
GroupPartitionsExecrepresentation in plans.Before this PR:
After this PR:
Why are the changes needed?
expectedPartitionKeysmight be huge and as it is based onInternalRowit doesn't make sense to display.Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Added new UT.
Was this patch authored or co-authored using generative AI tooling?
No.